pjfanning commented on PR #65: URL: https://github.com/apache/incubator-pekko-connectors/pull/65#issuecomment-1471957684
@mdedetrich could you have a look? In Alpakka, they removed scala 2.12 support over a year ago. We're supposed to support Scala 2.12. The most affected code is in the S3 module that you have been the main recent contributor to. * we could choose to just use plain Seqs instead of immutable.Seqs which would make the code more easily compiled in Scala 2.12 and Scala 2.13 * I'm using toIndexedSeq to convert plain Seqs to immutable.Seqs (the function returns an immutable.IndexedSeq) - a function that is readily available in the SDK) * or I could introduce code to convert plain Seqs to immutable.Seqs (a no-op in Scala 2.13 and for Scala 2.12, I could provide an optimised -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
