mdedetrich commented on PR #65: URL: https://github.com/apache/incubator-pekko-connectors/pull/65#issuecomment-1472150230
I am not sure if using `immutable.Seq` is desirable here because the point of using normal `Seq` is that it also accepts mutable collections which can be relevant from the Java side of things. Also note that other akka/pekko libraries have abstracted over these interfaces (such as `IndexedSeq`) in a similar way to scala-collection-compat but in a much more simple way and to me I think this is preferable. I have to look at this more concretely though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
