mdedetrich commented on code in PR #31:
URL:
https://github.com/apache/incubator-pekko-persistence-cassandra/pull/31#discussion_r1143117018
##########
build.sbt:
##########
@@ -19,17 +15,15 @@ lazy val root = project
.settings(name := "pekko-persistence-cassandra-root", publish / skip := true)
lazy val dumpSchema = taskKey[Unit]("Dumps cassandra schema for docs")
-dumpSchema := (core / Test / runMain).toTask("
akka.persistence.cassandra.PrintCreateStatements").value
+dumpSchema := (core / Test / runMain).toTask("
org.apache.pekko.persistence.cassandra.PrintCreateStatements").value
lazy val core = project
.in(file("core"))
.enablePlugins(Common, AutomateHeaderPlugin, MultiJvmPlugin)
.dependsOn(cassandraLauncher % Test)
.settings(
name := "pekko-persistence-cassandra",
- libraryDependencies ++= Dependencies.akkaPersistenceCassandraDependencies,
- Compile / packageBin / packageOptions += Package.ManifestAttributes(
Review Comment:
Why was this removed, or asked differently what is `"Automatic-Module-Name"`
for?
##########
example/src/main/scala/org/apache/pekko/persistence/cassandra/example/EventProcessorStream.scala:
##########
@@ -85,7 +85,7 @@ class EventProcessorStream[Event: ClassTag](
private def readOffset(): Future[Offset] = {
session
.selectOne(
- "SELECT timeUuidOffset FROM akka.offsetStore WHERE eventProcessorId =
? AND tag = ?",
+ "SELECT timeUuidOffset FROM pekko.offsetStore WHERE eventProcessorId =
? AND tag = ?",
Review Comment:
Not strictly related to review, but I think we probably need to provide an
SQL migration script. Should be discussed on mailing list @pjfanning
##########
docs/src/main/paradox/overview.md:
##########
@@ -14,17 +14,17 @@ This plugin requires **Akka $akka.version$** or later. See
[Akka's Binary Compat
group=com.typesafe.akka
artifact=akka-persistence-cassandra_$scala.binary.version$
version=$project.version$
- symbol=AkkaVersion
+ symbol=pekkoVersion
Review Comment:
Why did this get changed to lower case, can it be `PekkoVersion` to make
sure its consistent with the other projects? (note there are other cases of
this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
