mdedetrich commented on code in PR #31:
URL:
https://github.com/apache/incubator-pekko-persistence-cassandra/pull/31#discussion_r1143200999
##########
build.sbt:
##########
@@ -19,17 +15,15 @@ lazy val root = project
.settings(name := "pekko-persistence-cassandra-root", publish / skip := true)
lazy val dumpSchema = taskKey[Unit]("Dumps cassandra schema for docs")
-dumpSchema := (core / Test / runMain).toTask("
akka.persistence.cassandra.PrintCreateStatements").value
+dumpSchema := (core / Test / runMain).toTask("
org.apache.pekko.persistence.cassandra.PrintCreateStatements").value
lazy val core = project
.in(file("core"))
.enablePlugins(Common, AutomateHeaderPlugin, MultiJvmPlugin)
.dependsOn(cassandraLauncher % Test)
.settings(
name := "pekko-persistence-cassandra",
- libraryDependencies ++= Dependencies.akkaPersistenceCassandraDependencies,
- Compile / packageBin / packageOptions += Package.ManifestAttributes(
Review Comment:
> I will add that back. If "Automatic-Module-Name" is in the manifest then
the module name is taken from it, otherwise the module name is derived from the
JAR file name.
Wasn't aware of this. In any case I think being explicit here is beneficial,
especially considering that we now have to deal with `org.apache.pekko` vs just
`pekko` due to the package name change so its good to be clear where we use the
`org.apache` prefix and where not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
