mdedetrich commented on PR #258: URL: https://github.com/apache/incubator-pekko/pull/258#issuecomment-1477908162
So one thing to note on this PR is that the workaround with using `-target` described in https://github.com/akka/akka/issues/27079 has been removed. because `-target` is now deprecated in the latest versions of Scala 2.12/Scala 2.13 and more importantly `-release` has since been fixed so the workaround is not neccessary. The original problem with `-release` was that it didn't properly link the JDK 8 runtime library however this has since been solved. As stated in https://github.com/apache/incubator-pekko/blob/main/project/JdkOptions.scala#L60-L67 this can be verified, and I can at least confirm on my end that `-release` has indeed been fixed, i.e. ``` <@incubator-pekko/r/t/s/c/o/a/p/r/artery>-<⎇ update-scala-versions>-<±>-<*>-2-> javap -c EnvelopeBuffer.class | grep "java/nio/ByteBuffer.clear:()Ljava/nio/Buffer" 9: invokevirtual #121 // Method java/nio/ByteBuffer.clear:()Ljava/nio/Buffer; ``` Works for both Scala 2.12 and Scala 2.13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
