He-Pin commented on code in PR #258:
URL: https://github.com/apache/incubator-pekko/pull/258#discussion_r1143646474
##########
project/JdkOptions.scala:
##########
@@ -57,14 +57,8 @@ object JdkOptions extends AutoPlugin {
targetSystemJdk,
jdk8home,
fullJavaHomes,
- Seq(if (scalaVersion.startsWith("3.")) "-Xtarget:8" else
"-target:jvm-1.8"),
- // '-release 8' is not enough, for some reason we need the 8 rt.jar
- // explicitly. To test whether this has the desired effect, compile
- // pekko-remote and check the invocation of 'ByteBuffer.clear()' in
- // EnvelopeBuffer.class with 'javap -c': it should refer to
- // ""java/nio/ByteBuffer.clear:()Ljava/nio/Buffer" and not
- // "java/nio/ByteBuffer.clear:()Ljava/nio/ByteBuffer". Issue #27079
- (java8home: File) => Seq("-release", "8", "-javabootclasspath",
java8home + "/jre/lib/rt.jar"))
+ Seq(if (scalaVersion.startsWith("3.")) "-Xtarget:8" else "release:8"),
Review Comment:
I have a PR related, let's me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
