mdedetrich commented on code in PR #258:
URL: https://github.com/apache/incubator-pekko/pull/258#discussion_r1143860934
##########
project/JdkOptions.scala:
##########
@@ -74,9 +68,7 @@ object JdkOptions extends AutoPlugin {
jdk8home,
fullJavaHomes,
Nil,
- // '-release 8' would be a neater option here, but is currently not an
- // option because it doesn't provide access to `sun.misc.Unsafe` #27079
- (java8home: File) => Seq("-source", "8", "-target", "8",
"-bootclasspath", java8home + "/jre/lib/rt.jar"))
+ (java8home: File) => Seq("-source", "8", "-target", "8"))
Review Comment:
I will mark this as resolved, made an issue at
https://github.com/apache/incubator-pekko/issues/262 where we can investigate
the removal of this workaround separately. Most critical thing for this PR
specifically is to update scalac versions because of a CVC.
@raboof @BalmungSan @He-Pin @som-snytt Thanks a ton for the
help/clarification
##########
project/JdkOptions.scala:
##########
@@ -74,9 +68,7 @@ object JdkOptions extends AutoPlugin {
jdk8home,
fullJavaHomes,
Nil,
- // '-release 8' would be a neater option here, but is currently not an
- // option because it doesn't provide access to `sun.misc.Unsafe` #27079
- (java8home: File) => Seq("-source", "8", "-target", "8",
"-bootclasspath", java8home + "/jre/lib/rt.jar"))
+ (java8home: File) => Seq("-source", "8", "-target", "8"))
Review Comment:
I will mark this as resolved, make an issue at
https://github.com/apache/incubator-pekko/issues/262 where we can investigate
the removal of this workaround separately. Most critical thing for this PR
specifically is to update scalac versions because of a CVC.
@raboof @BalmungSan @He-Pin @som-snytt Thanks a ton for the
help/clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
