mdedetrich commented on code in PR #258:
URL: https://github.com/apache/incubator-pekko/pull/258#discussion_r1143847839
##########
project/JdkOptions.scala:
##########
@@ -74,9 +68,7 @@ object JdkOptions extends AutoPlugin {
jdk8home,
fullJavaHomes,
Nil,
- // '-release 8' would be a neater option here, but is currently not an
- // option because it doesn't provide access to `sun.misc.Unsafe` #27079
- (java8home: File) => Seq("-source", "8", "-target", "8",
"-bootclasspath", java8home + "/jre/lib/rt.jar"))
+ (java8home: File) => Seq("-source", "8", "-target", "8"))
Review Comment:
> I'm not sure which issue I'm pinged about, but I remember 2.12 targets 8,
making Unsafe available is a pain, and also if there is a subtle breakage in
Java API then you may want to compile against rt.jar instead of using
`--release` (which uses the `ct.sym` file).
So it is specifically about targeting `rt.jar` with javac `-target` command
because of unsafe, i.e. `(java8home: File) => Seq("-source", "8", "-target",
"8", "-bootclasspath", java8home + "/jre/lib/rt.jar"))` in
https://github.com/apache/incubator-pekko/pull/258/files#diff-c11a10bd9e773399e4272cd1ee5dff72545afb2f8bed23f2d1bbc49d4e1fc03fR73
It does sound like from what you are saying that we should just leave this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
