mdedetrich commented on code in PR #171:
URL:
https://github.com/apache/incubator-pekko-http/pull/171#discussion_r1218026521
##########
build.sbt:
##########
@@ -42,7 +42,9 @@ inThisBuild(Def.settings(
},
scalafixScalaBinaryVersion := scalaBinaryVersion.value,
apacheSonatypeProjectProfile := "pekko",
- versionScheme := Some("semver-spec")))
+ versionScheme := Some("semver-spec"),
+ // TODO: Remove when Pekko has a proper release
+ updateOptions := updateOptions.value.withLatestSnapshots(false)))
Review Comment:
Theoretically speaking it can have impacts if you for example are publishing
a local version of pekko core that always points to a single version. This
workflow is quite typical, i.e. you are doing some fix in pekko-http that
requires a change in pekko.
If you have `updateOptions :=
updateOptions.value.withLatestSnapshots(false))` it doesn't distinguish between
local repos or remote repos which means that it will break this workflow in
very subtly surprising ways (i.e. I keep on doing `publishLocal`, why isn't it
updating????).
This is honestly designed to be temporary, after a release we shouldn't be
relying on any shapshots.
##########
build.sbt:
##########
@@ -42,7 +42,9 @@ inThisBuild(Def.settings(
},
scalafixScalaBinaryVersion := scalaBinaryVersion.value,
apacheSonatypeProjectProfile := "pekko",
- versionScheme := Some("semver-spec")))
+ versionScheme := Some("semver-spec"),
+ // TODO: Remove when Pekko has a proper release
+ updateOptions := updateOptions.value.withLatestSnapshots(false)))
Review Comment:
Practically speaking it can have impacts if you for example are publishing a
local version of pekko core that always points to a single version. This
workflow is quite typical, i.e. you are doing some fix in pekko-http that
requires a change in pekko.
If you have `updateOptions :=
updateOptions.value.withLatestSnapshots(false))` it doesn't distinguish between
local repos or remote repos which means that it will break this workflow in
very subtly surprising ways (i.e. I keep on doing `publishLocal`, why isn't it
updating????).
This is honestly designed to be temporary, after a release we shouldn't be
relying on any shapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
