mdedetrich commented on code in PR #171:
URL:
https://github.com/apache/incubator-pekko-http/pull/171#discussion_r1221418523
##########
build.sbt:
##########
@@ -42,7 +42,9 @@ inThisBuild(Def.settings(
},
scalafixScalaBinaryVersion := scalaBinaryVersion.value,
apacheSonatypeProjectProfile := "pekko",
- versionScheme := Some("semver-spec")))
+ versionScheme := Some("semver-spec"),
+ // TODO: Remove when Pekko has a proper release
+ updateOptions := updateOptions.value.withLatestSnapshots(false)))
Review Comment:
Sure, honestly the real problem here is that
`updateOptions.value.withLatestSnapshots(false))` is not granular. In an idea
world you would be able to set
`updateOptions.value.withLatestSnapshots(false))` for artifacts that are only
download remotely where we can verify that snapshots are immutable since they
are version with git hashes from `main` branch.
I think we are scraping the bottom of the barrel a bit here, this is meant
to be a temporary work around so we don't overload the ASF repo with requests
and while there may be arguments for leaving
`updateOptions.value.withLatestSnapshots(false))` after release there is also a
reason why the default of `withLatestSnapshots` is `true` in that its
incredibly frustrating/surprising when you actually happen to have mutable
snapshots. The overloading of requests is not going to be an issue if a person
occasionally uses snapshots locally, its an issue if we have 12+ repo's
building nightly snapshots resolving against pekko snapshots.
@pjfanning Is this PR still a real blocker for you? We can always
revert/revisit this later but the equivalent of these changes have already been
merged in other pekko modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
