mdedetrich commented on PR #371:
URL: https://github.com/apache/incubator-pekko/pull/371#issuecomment-1580695434
So I have just updated the tests and rebased/force pushed the changes. The
reason why the tests are failing is that they assumed the `nextId` was
incrementally increasing and hence checking against raw id's. I have updated
the tests so that we don't test against the id's but the properties for the id,
i.e. typically speaking the test expects an initial id from the `dnsClient1`
i.e.
```scala
val firstId = dnsClient1.expectMsgPF() {
case q4: Question4 if q4.name == "cats.com" =>
q4.id
}
```
and then that `secondId` is being reused in later on, such as
```scala
val secondId = dnsClient2.expectMsgPF() {
case q4: Question4 if q4.name == "cats.com" && q4.id != firstId =>
q4.id
}
```
i.e. in this specific case we can't test for hardcoded id's but we can still
make sure that the `secondId` is not the same as the `firstId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
