He-Pin commented on PR #371: URL: https://github.com/apache/incubator-pekko/pull/371#issuecomment-1580996162
> > `nextId` can be called concurrently, so I think two thread can get the same result. `idIncrement` and `idIndex` should be protected with `AtomicLong` > > So having gone through the codebase, `nextId()` is only called in a `receive` block (indirectly) which means that its only going to be called in a single threaded context (this is something that actor guarantees). > > Did I miss something? IIRC, it can be called from the `recover` of the future。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
