pjfanning commented on PR #142: URL: https://github.com/apache/incubator-pekko-connectors/pull/142#issuecomment-1582520361
> ill approve although I don't really like unit tests that are testing just the compiler. Since we are going to integrate Scala 3 into pekko-connectors anyways, I would prefer not having the test or alternately creating an issue to remove it when we add scala 3 support. I'm not testing the compiler - I'm testing that the call completes ok - the test runs into an indefinite loop without my fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
