mdedetrich commented on PR #142: URL: https://github.com/apache/incubator-pekko-connectors/pull/142#issuecomment-1582525494
> > ill approve although I don't really like unit tests that are testing just the compiler. Since we are going to integrate Scala 3 into pekko-connectors anyways, I would prefer not having the test or alternately creating an issue to remove it when we add scala 3 support. > > I'm not testing the compiler - I'm testing that the call completes ok - the test runs into an indefinite loop without my fix Yes I know, I didn't expressive well. What I mean is that I am not a fan of unit tests that are covering for issues that the compiler should detect/show mainly because you can argue "why don't we just add a unit test for every possible apply method that can create an infinite recursive loop". Put differently the test sticks out as a sore thumb. This has also revealed that huawei pushkit evidently doesn't have good enough integration test coverage (which would not only uncover this issue but actually test the library in general). As I said though, I wouldn't be saying this if Scala 3 didn't happen to catch this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
