mdedetrich commented on PR #371: URL: https://github.com/apache/incubator-pekko/pull/371#issuecomment-1584235925
@He-Pin @pjfanning I have updated a PR for a new implementation provided by @Claudenw . The new implementation guarantees no hash collisions until it loops through all possible 65536 values. This is achieved by using a prefilled array buffer. While this means the algorithm does take up a decent amount of memory (~131072 bytes) this allocation only actually occurs if you call `UniqueRandomShortProvider.nextId()` which means you don't pay for it if you don't use it and 131072 bytes is all things considered a very tiny amount when it comes to modern machines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
