pjfanning commented on code in PR #385:
URL: https://github.com/apache/incubator-pekko/pull/385#discussion_r1226473593
##########
actor/src/main/scala/org/apache/pekko/io/dns/internal/AsyncDnsResolver.scala:
##########
@@ -41,10 +43,17 @@ import pekko.util.PrettyDuration._
private[io] final class AsyncDnsResolver(
settings: DnsSettings,
cache: SimpleDnsCache,
- clientFactory: (ActorRefFactory, List[InetSocketAddress]) =>
List[ActorRef])
+ clientFactory: (ActorRefFactory, List[InetSocketAddress]) =>
List[ActorRef],
+ idGenerator: IdGenerator)
extends Actor
with ActorLogging {
+ def this(
Review Comment:
Seems useful to maintain compatibility but we can document any places where
we need to break compatibility. For me, Pekko is a new project and users
already have to migrate package names, config names, some class names - so we
are already not fully compatible with Akka.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
