mdedetrich commented on code in PR #385:
URL: https://github.com/apache/incubator-pekko/pull/385#discussion_r1226476375
##########
actor/src/main/scala/org/apache/pekko/io/dns/internal/AsyncDnsResolver.scala:
##########
@@ -41,10 +43,17 @@ import pekko.util.PrettyDuration._
private[io] final class AsyncDnsResolver(
settings: DnsSettings,
cache: SimpleDnsCache,
- clientFactory: (ActorRefFactory, List[InetSocketAddress]) =>
List[ActorRef])
+ clientFactory: (ActorRefFactory, List[InetSocketAddress]) =>
List[ActorRef],
+ idGenerator: IdGenerator)
extends Actor
with ActorLogging {
+ def this(
Review Comment:
Indeed binary compatibility from Akka is a non concern here since we don't
support mixing them, source compatibility is more important here, that is if we
dont need to do anything additional side from the package name/prefix migration
renames.
Thats not to say there is a problem with this but if adding binary
compatibility is going to be worse design wise we shouldn't need to handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
