pjfanning commented on PR #445: URL: https://github.com/apache/incubator-pekko/pull/445#issuecomment-1618323129
@thmue the timing of this PR is a little unfortunate. We are trying to get 1.0.0 released and this is not going in it. We can merge this change later but I would still like to get more opinions on it. To me, supporting junit5 in just one testkit is a bit strange but other users might disagree. One technical thing. The source code header you've added to the new files - that code is new and not Akka derived. So, the right header to use is arguably the one in https://www.apache.org/legal/src-headers.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
