mdedetrich commented on code in PR #445: URL: https://github.com/apache/incubator-pekko/pull/445#discussion_r1278578942
########## actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/javadsl/Junit5TestKitBuilder.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.actor.testkit.typed.javadsl + +import com.typesafe.config.Config +import org.apache.pekko.actor.testkit.typed.internal.TestKitUtils +import org.apache.pekko.actor.testkit.typed.scaladsl.ActorTestKit.ApplicationTestConfig +import org.apache.pekko.actor.typed.ActorSystem + +case class Junit5TestKitBuilder() { Review Comment: Is there a reason this is a `case class`? There are no fields in the constructor, it honestly looks like it should be a normal class. ########## actor-testkit-typed/src/test/java/jdocs/org/apache/pekko/actor/testkit/typed/javadsl/GreeterMain.scala: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * This file is part of the Apache Pekko project, which was derived from Akka. + */ + +package jdocs.org.apache.pekko.actor.testkit.typed.javadsl + +import org.apache.pekko.actor.typed.{ ActorRef, Behavior } Review Comment: Can we use this following import style ```scala import org.apache.pekko import pekko.actor.typed.{ ActorRef, Behavior } import pekko.actor.typed.scaladsl.Behaviors ``` ########## actor-testkit-typed/src/test/scala/org/apache/pekko/actor/testkit/typed/scaladsl/Junit5TestKitBuilderSpec.scala: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.actor.testkit.typed.scaladsl + +import com.typesafe.config.ConfigFactory +import jdocs.org.apache.pekko.actor.testkit.typed.javadsl.GreeterMain +import org.apache.pekko.actor.testkit.typed.javadsl.Junit5TestKitBuilder Review Comment: Can we use this following import style ```scala import org.apache.pekko import pekko.actor.testkit.typed.javadsl.Junit5TestKitBuilder import pekko.actor.typed.ActorSystem ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
