mdedetrich commented on code in PR #106: URL: https://github.com/apache/incubator-pekko-grpc/pull/106#discussion_r1252867936
########## sbt-plugin/src/sbt-test/gen-scala-server/01-gen-basic-server/build.sbt: ########## @@ -2,7 +2,9 @@ // https://github.com/akka/akka-grpc/pull/1279 scalaVersion := "2.12.18" +// TODO remove these resolvers when we start using released Pekko jars resolvers += Resolver.ApacheMavenSnapshotsRepo +resolvers += "apache-staging".at("https://repository.apache.org/content/groups/staging/";) Review Comment: This would require an upstream contribution to sbt, not against it but there are pros and cons to this. Our usage of staging here is temporary (due to 1.0.0-RC3), once the first release of Pekko is made it will never be in the codebase again. ########## sbt-plugin/src/sbt-test/gen-scala-server/01-gen-basic-server/build.sbt: ########## @@ -2,7 +2,9 @@ // https://github.com/akka/akka-grpc/pull/1279 scalaVersion := "2.12.18" +// TODO remove these resolvers when we start using released Pekko jars resolvers += Resolver.ApacheMavenSnapshotsRepo +resolvers += "apache-staging".at("https://repository.apache.org/content/groups/staging/";) Review Comment: This would require an upstream contribution to sbt, not against it but there are pros and cons to this. Our usage of staging here is temporary (due to 1.0.0-RC3), once the first release of Pekko/pekko-http is made it will never be in the codebase again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
