[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #106: Update latest pekko-http to bring in cors

Wed, 05 Jul 2023 03:29:36 -0700 


mdedetrich commented on code in PR #106:
URL: 
https://github.com/apache/incubator-pekko-grpc/pull/106#discussion_r1252901514


##########
docs/src/main/paradox/server/grpc-web.md:
##########
@@ -37,9 +37,9 @@ gRPC-Web endpoint with basic CORS infrastructure in place. To 
use CORS,
 you will need to add the pekko-http-cors dependency to your project:
 
 @@dependency[sbt,Maven,Gradle] {
-  group="ch.megard"
+  group="org.apache.pekko"
   artifact="pekko-http-cors_2.12"
-  version="0.0.0-SNAPSHOT" // Update when proper release of pekko-http-cors is 
made
+  version="0.0.0-4456-9a4c0fc7-SNAPSHOT" // Update when proper release of 
pekko-http-cors is made

Review Comment:
   Just pushed and I can confirm its rendering correctly, i.e.
   
   
![image](https://github.com/apache/incubator-pekko-grpc/assets/2337269/691448ba-f57e-41e2-b45f-002f7a0736a0)
   
   
![image](https://github.com/apache/incubator-pekko-grpc/assets/2337269/250cd862-a64a-49bc-b57a-4bd5d79ac029)
   
   
![image](https://github.com/apache/incubator-pekko-grpc/assets/2337269/80124481-5477-4a32-99e3-9369bae66fb4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to