mdedetrich commented on code in PR #44:
URL:
https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257967998
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/JournalSequenceActor.scala:
##########
@@ -48,15 +48,15 @@ object JournalSequenceActor {
* Efficient representation of missing elements using NumericRanges.
* It can be seen as a collection of OrderingIds
*/
- private case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
+ final case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
Review Comment:
This is due to
```
[error] -- Error:
/Users/mdedetrich/github/incubator-pekko-persistence-jdbc/core/src/main/scala/org/apache/pekko/persistence/jdbc/query/JournalSequenceActor.scala:97:6
[error] 97 | def receive(
[error] | ^
[error] |non-private method receive in class JournalSequenceActor refers
to private class MissingElements
[error] |in its type signature (
[error] | currentMaxOrdering:
[error] |
org.apache.pekko.persistence.jdbc.query.JournalSequenceActor.OrderingId,
[error] | missingByCounter:
[error] | Map[Int,
[error] |
org.apache.pekko.persistence.jdbc.query.JournalSequenceActor.
[error] | MissingElements
[error] | ]
[error] | ,
[error] |moduloCounter: Int, previousDelay:
concurrent.duration.FiniteDuration):
[error] | JournalSequenceActor.this.Receive
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
