mdedetrich commented on code in PR #44:
URL:
https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1258040292
##########
.github/workflows/checks.yml:
##########
@@ -66,7 +66,7 @@ jobs:
- name: Compile all code with fatal warnings for Java 11, Scala 2.12 and
Scala 2.13
# Run locally with: sbt 'clean ; +Test/compile ; +It/compile'
- run: sbt "; Test/compile; It/compile"
Review Comment:
This wasn't even properly cross compiling, i.e. it was only compiling for
the default Scala version and not all of `CrossScalaVersions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
