mdedetrich commented on PR #117: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1652615551
> We have 3 choices about the 1.0.0 docs for pekko-connectors-kafka: > > 1. merge this and generate the 1.0.0 docs with this change - which will have a slightly incorrect report about rs-api jar > 2. merge this but set up the 1.0 doc publish job to use the git ref with the 1.0.0 git tag when generating the 1.0.0 docs > 3. delay merging this until after we generate the 1.0.0 docs Well I would say that we have 2 choices, choice 3 doesn't give us buy as anything (as you said we can always just make sure the job uses git ref when publishing docs, this is a non issue). If https://github.com/apache/incubator-pekko-connectors-kafka/pull/116 wasn't merged then there might have a slight case of not merging this PR, but alas thats not the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
