mdedetrich commented on PR #117: URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1660755681
> > @pjfanning So the vote for this project passed, what are your thoughts on this? > > * The new 1.0.0 jars should be built off the commit that was voted on so merging this does not affect that. > * We don't yet have 1.0.0 docs published. We could choose to build those from the same commit as we voted on or we could build them based on latest commits (including this). I think it isn't a big deal if the license report is slightly incorrect (rs-api jar has been upgraded since the vote was called). Okay, I will build off the 1.0.0-RC1 commit and we can merge this for the docs, as you said I don't think a test dependency being slightly incorrect is a big deal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
