jrudolph commented on code in PR #489:
URL: https://github.com/apache/incubator-pekko/pull/489#discussion_r1278598230
##########
LICENSE:
##########
@@ -353,12 +353,6 @@ Copyright 2014 - 2016 Real Logic Ltd.
---------------
-pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
Do we already have a notice that we publish the v3 versions? If not, maybe
we can repurpose this one.
##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -484,8 +484,7 @@ class Serialization(val system: ExtendedActorSystem)
extends Extension {
// include "com.google.protobuf.GeneratedMessage" = proto in configured
serialization-bindings.
private def checkGoogleProtobuf(className: String): Boolean =
checkClass("com.google.protobuf", className)
- // pekko-protobuf is now not a dependency of remote so only load if user has
explicitly added it
- // remove in v1.1
+ // pekko-protobuf-v3
Review Comment:
The method itself should probably also go? The v3 package is called
`org.apache.pekko.protobufv3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
