pjfanning commented on code in PR #489:
URL: https://github.com/apache/incubator-pekko/pull/489#discussion_r1278601676
##########
actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala:
##########
@@ -484,8 +484,7 @@ class Serialization(val system: ExtendedActorSystem)
extends Extension {
// include "com.google.protobuf.GeneratedMessage" = proto in configured
serialization-bindings.
private def checkGoogleProtobuf(className: String): Boolean =
checkClass("com.google.protobuf", className)
- // pekko-protobuf is now not a dependency of remote so only load if user has
explicitly added it
- // remove in v1.1
+ // pekko-protobuf-v3
Review Comment:
This function is still used inside Serialization.scala.
If it is ok, I can create a separate issue to investigate what happens if we
remove this function but I suspect it could cause trouble for the code that
uses pekko-protobuf-v3 jar if we remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
