mdedetrich commented on code in PR #539:
URL: https://github.com/apache/incubator-pekko/pull/539#discussion_r1285186007
##########
project/SbtMultiJvm.scala:
##########
@@ -372,7 +373,13 @@ object MultiJvmPlugin extends AutoPlugin {
val connectInput = input && index == 0
log.debug("Starting %s for %s".format(jvmName, testClass))
log.debug(" with JVM options: %s".format(allJvmOptions.mkString(" ")))
- (testClass, Jvm.startJvm(javaBin, allJvmOptions, runOptions,
jvmLogger, connectInput))
+ val testClass2Process = (testClass, Jvm.startJvm(javaBin,
allJvmOptions, runOptions, jvmLogger, connectInput))
+ if (index == 0) {
+ log.debug("%s for %s 's started as `Controller`, waiting 2 seconds
before start clients.".format(jvmName,
+ testClass))
+ TimeUnit.SECONDS.sleep(2)
Review Comment:
Regarding this point in general, maybe it makes sense to make this a
separate issue to look at after this PR gets merged? The reason I am stating
this is because the best way to find out if these time based constants are too
low is by seeing how often the tests fail in our nightly github CI action and
we can then iterate from there.
Of course most ideal would be to ping the netty cluster until its ready but
I don't feel its valid to block the PR over this, for me its critical to get
people to test this directly (via snpashots/building locally), hopefully in
production to see if there aren't any regressions well before a release happens.
Note that @He-Pin already solved this issue in this specific case, my point
was more talking about the other time waiting constants in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
