mdedetrich commented on code in PR #539:
URL: https://github.com/apache/incubator-pekko/pull/539#discussion_r1285189073
##########
project/SbtMultiJvm.scala:
##########
@@ -167,10 +168,11 @@ object MultiJvmPlugin extends AutoPlugin {
// the first class wins just like a classpath
// just concatenate conflicting text files
assembly / assemblyMergeStrategy := {
- case n if n.endsWith(".class") => MergeStrategy.first
- case n if n.endsWith(".txt") => MergeStrategy.concat
- case n if n.endsWith("NOTICE") => MergeStrategy.concat
- case n => (assembly /
assemblyMergeStrategy).value.apply(n)
+ case n if n.endsWith(".class") => MergeStrategy.first
+ case n if n.endsWith(".txt") => MergeStrategy.concat
+ case n if n.endsWith("NOTICE") => MergeStrategy.concat
+ case n if n.endsWith("LICENSE") => MergeStrategy.concat
Review Comment:
Yes please make a separate PR for this. Although it's true that this only
effects netty 4 for now, in general if there multiple `LICENSE`'s we do want to
concat them (i.e. this isn't just specific to netty 4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
