mdedetrich commented on PR #280: URL: https://github.com/apache/incubator-pekko-connectors/pull/280#issuecomment-1807223710
@pjfanning So this is the PR that actually changes public signatures and it did trigger a MiMa incompatiblity check but it can be a false positive, i.e. see https://github.com/lightbend/mima#incompatiblesignatureproblem which I believe is the case. I can double check this by writing a program that is compiled against `Sink[(UploadPartResponse, immutable.Iterable[C]), NotUsed]` and then at runtime loading a pekko-connectors-s3 jar that is compiled with `Sink[(UploadPartResponse, immutable.Iterable[C]), _]` to see if it fails at runtime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
