mdedetrich commented on PR #280:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/280#issuecomment-1807748739
@pjfanning So I can indeed confirm that the warning from MiMa in this case
is a false positive and this PR doesn't actually break any binary compatiblity.
The easiest way to confirm this is to hot patch the s3 tests so that at
runtime rather than using the compiled classes from `s3` project it uses a
locally deployed S3 that has the change in this PR, to do this
* Checkout this PR's branch and run `+s3/publishLocal`
* Checkout `main`
* Modify the `s3` project in `build.sbt` so it looks like this
*
```scala
lazy val s3 = pekkoConnectorProject("s3", "aws.s3", Dependencies.S3,
MetaInfLicenseNoticeCopy.s3Settings)
.settings(
Test / fullClasspath := {
val current = (Test / fullClasspath).value
current.map {
case f if
f.data.getAbsolutePath.contains("s3/target/scala-2.13/classes") =>
Attributed[File](
file(
"/Users/mdedetrich/.ivy2/local/org.apache.pekko/pekko-connectors-s3_2.13/1.0.1+9-575983c5-SNAPSHOT/jars/pekko-connectors-s3_2.13.jar"))(
AttributeMap.empty)
case rest => rest
}
})
```
Make sure to change the paths where neccessary, i.e. the local path to
where you just published S3.
* Run the tests with `s3/test`
What this change does it **only** modifies the test classpath which means
that when you do `s3/test/compile` it will generate classes without the change
in this branch (since you should be checked out in `main`) but when you run the
tests with `s3/test` it will use the jar with the change in this branch which
you just published locall (note that compiled test code, i.e. the tests written
in scala-test sits in `test-classes` so its unchanged by this hotpatch)
You can play around with `show s3/Test/fullClasspath` to confirm this.
The PR has been updated to add the various MiMa filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
