mdedetrich commented on code in PR #394:
URL:
https://github.com/apache/incubator-pekko-http/pull/394#discussion_r1439982745
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/settings/Http2ServerSettings.scala:
##########
@@ -124,6 +137,10 @@ object Http2ServerSettings extends
SettingsCompanion[Http2ServerSettings] {
logFrames: Boolean,
pingInterval: FiniteDuration,
pingTimeout: FiniteDuration,
+ frameTypeThrottleFrameTypes: Seq[String],
Review Comment:
This should be a `Set`
##########
http-core/src/main/resources/reference.conf:
##########
@@ -307,6 +307,17 @@ pekko.http {
# Fail the connection if a sent ping is not acknowledged within this
timeout.
# When zero the ping-interval is used, if set the value must be evenly
divisible by less than or equal to the ping-interval.
ping-timeout = 0s
+
+ frame-type-throttle {
+ # Configure the throttle for non-data frame types
(https://github.com/apache/incubator-pekko-http/issues/332)
+ # supported frame-types for throttlng are:
+ # reset, headers, continuation, go-away, priority, ping, push-promise,
window-update
Review Comment:
While we are here, should we documented a suggested list of frame types
and/or should we create an alias for all of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
