He-Pin commented on code in PR #394: URL: https://github.com/apache/incubator-pekko-http/pull/394#discussion_r1458901335
########## http-core/src/main/scala/org/apache/pekko/http/scaladsl/settings/Http2ServerSettings.scala: ########## @@ -102,6 +103,18 @@ trait Http2ServerSettings extends javadsl.settings.Http2ServerSettings with Http def pingTimeout: FiniteDuration def withPingTimeout(timeout: FiniteDuration): Http2ServerSettings = copy(pingTimeout = timeout) + def frameTypeThrottleFrameTypes: Set[String] + def withFrameTypeThrottleFrameTypes(frameTypes: Set[String]) = copy(frameTypeThrottleFrameTypes = frameTypes) + + def frameTypeThrottleCost: Int + def withFrameTypeThrottleCost(cost: Int) = copy(frameTypeThrottleCost = cost) + + def frameTypeThrottleBurst: Int + def withFrameTypeThrottleBurst(burst: Int) = copy(frameTypeThrottleBurst = burst) + + def frameTypeThrottleInterval: FiniteDuration + def withFrameTypeThrottleInterval(interval: FiniteDuration) = copy(frameTypeThrottleInterval = interval) Review Comment: use `java.time.Duration` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
