mdedetrich commented on PR #902: URL: https://github.com/apache/incubator-pekko/pull/902#issuecomment-1876268471
> @mdedetrich Ok. let me remove it for now, and let the JVM jit do the thing, as these are private method. If you can prove that both the scala-2 and scala-3 inliner makes a performance impact then you can make both the `@inline` and `inline` keyword variants. Also do note that the Scala 2 inliner is now enabled for the entire codebase, so if the default heuristics for the Scala 2 inliner think that the method should be inlined then it will. If you want to verify that the scala 2 inliner is actually inlining those methods (or not) then you can use the `sbt -Dpekko.no.inline=yes` to turn off the inliner (make sure to do `clean` inbetween switching on and off the inliner). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
