He-Pin commented on code in PR #902:
URL: https://github.com/apache/incubator-pekko/pull/902#discussion_r1441322786
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##########
@@ -1007,8 +1007,7 @@ trait FlowOps[+Out, +Mat] {
*
* '''Cancels when''' downstream cancels
*/
- @nowarn("msg=deprecated")
- def mapConcat[T](f: Out => IterableOnce[T]): Repr[T] = statefulMapConcat(()
=> f)
+ def mapConcat[T](f: Out => IterableOnce[T]): Repr[T] = via(new MapConcat(f))
Review Comment:
1. the javadsl's mapconcat is using scaladsl's mapconcat
2. case class will make the jar bigger and we have no pattern matching here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
