pjfanning commented on code in PR #394:
URL:
https://github.com/apache/incubator-pekko-http/pull/394#discussion_r1458985616
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/settings/Http2ServerSettings.scala:
##########
@@ -136,6 +153,7 @@ object Http2ServerSettings extends
SettingsCompanion[Http2ServerSettings] {
require(minCollectStrictEntitySize <= (incomingConnectionLevelBufferSize /
maxConcurrentStreams),
"min-collect-strict-entity-size <= incoming-connection-level-buffer-size
/ max-concurrent-streams")
require(outgoingControlFrameBufferSize > 0,
"outgoing-control-frame-buffer-size must be > 0")
+ require(frameTypeThrottleInterval.toMillis > 0,
"frame-type-throttle.interval must be a positive duration")
Review Comment:
I still think this is better to not allow bad values - the default value is
ok and we have a warning in the reference.conf.
And it is more efficient to do 1 check instead of 2 checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
