mdedetrich commented on code in PR #982:
URL: https://github.com/apache/incubator-pekko/pull/982#discussion_r1459998741
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala:
##########
@@ -267,9 +266,8 @@ private[stream] object Collect {
} catch {
case NonFatal(ex) =>
decider(ex) match {
- case Supervision.Stop => failStage(ex)
- case Supervision.Resume => if (!hasBeenPulled(in)) pull(in)
Review Comment:
> Why? the Map and Filter don't have this either.
We should add the comments there as well then. Its more that when other
people that are not so familiar with Akka/Pekko read the code they get a better
understanding of why these exceptions are there.
Akka's problem historically is that a lot of the contributions were done
within Lightbend and so there is a lot of inhouse knowledge that wasn't visible
to outside contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
