He-Pin commented on code in PR #982:
URL: https://github.com/apache/incubator-pekko/pull/982#discussion_r1460289557
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/Ops.scala:
##########
@@ -267,9 +266,12 @@ private[stream] object Collect {
} catch {
case NonFatal(ex) =>
decider(ex) match {
- case Supervision.Stop => failStage(ex)
- case Supervision.Resume => if (!hasBeenPulled(in)) pull(in)
- case Supervision.Restart => if (!hasBeenPulled(in)) pull(in)
+ case Supervision.Stop => failStage(ex)
+ case _ =>
+ // The !hasBeenPulled(in) check is not required here since it
Review Comment:
I see, hah, The chinese networking to github is very unstable, that's why I
hate changing and changing, sometime I can't pulling pull too, both via ssh and
https
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
