mdedetrich commented on code in PR #1047:
URL: https://github.com/apache/incubator-pekko/pull/1047#discussion_r1467192023
##########
project/Jdk9.scala:
##########
@@ -52,7 +52,10 @@ object Jdk9 extends AutoPlugin {
// so we add them to the fullClasspath instead.
// Compile / packageBin / mappings
// ++= (CompileJdk9 / products).value.flatMap(Path.allSubpaths),
- Compile / fullClasspath ++= (CompileJdk9 / exportedProducts).value)
+ // Since sbt-osgi upgrade to 0.9.5, the fullClasspath is no longer used on
packaging when use sbt-osgi, so we have to
+ // add jdk9 products to dependencyClasspathAsJars instead.
+ // Compile / fullClasspath ++= (CompileJdk9 / exportedProducts).value)
Review Comment:
This line can be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
