Roiocam commented on PR #1047: URL: https://github.com/apache/incubator-pekko/pull/1047#issuecomment-1911771654
> I will defer to @Roiocam w/e he thinks is best. @Roiocam If you want us to merge the PR as is so you can make a new one just let me know. I have investigated the problem of protobuf-v3 for a while, and I don't think there is any problem with the existing methods. Since the `sbt-osgi` upgrade, there dependency has big change, but `sbt-assembly` only depends on `Compile / fullClasspath`, we could make `osgiBundle` depends on `sbt-assembly`, but they assembly result won't compact to osgi jar. I think we could make this PR merged, and then use another issue to find out if it has a better solution for `sbt-assembly` or not. ```diff 10a11,12 > [info] protobuf-v3 / Compile / dependencyClasspathAsJars > [info] protobuf-v3 / osgiCacheBundle 13d14 < [info] protobuf-v3 / Compile / fullClasspath 20a22 > [info] protobuf-v3 / Compile / products ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
