mdedetrich commented on PR #1064: URL: https://github.com/apache/incubator-pekko/pull/1064#issuecomment-1913547643
> @mdedetrich The difference is that this approach can test whether the final product really works properly, rather than just checking if xxx.class exists using grep. I think this is a relatively advantageous point. In addition, it can expand to test multiple platforms' products, while if you use grep xxx.class in the end, can only determine whether xxx.class exists, right? At least I saw that Dotty uses this approach as well. I understand and I will accept either solution. My main reason for suggesting the simpler approach is that our issue is quite black and white, either the JDK 9 classes don't get generated at all or they get generated with the correct JDK version and if they do its completely correct. Hence I think that checking whether it works is a bit excessive because at that point we are basically checking the scalac compiler is working where as what our historic issue has been is that the misconfiguration of sbt-osgi/multijvm/etc etc means that certain classes don't get compiled/included -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
