Roiocam commented on code in PR #1064: URL: https://github.com/apache/incubator-pekko/pull/1064#discussion_r1468868413
########## project/VerifyJDK9Classes.scala: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +object VerifyJDK9Classes { + import sbt._ + import sbt.Keys._ + + lazy val settings: Seq[Setting[_]] = inConfig(Compile) { + Seq { + sourceGenerators += { + generateAndWriteScalaCLIScript( + target, + _ / "scala-cli" / "VerifyJDK9Classes.sc") + } + } + } + + def generateAndWriteScalaCLIScript(dir: SettingKey[File], locate: File => File): Def.Initialize[Task[Seq[sbt.File]]] = + Def.task[Seq[File]] { + val script = generateScalaCLIScript(version.value) + val file = locate(dir.value) + val content = script.stripMargin.format(version.value) + if (!file.exists || IO.read(file) != content) IO.write(file, content) + // the generated file is not used. + Nil + } + + private def generateScalaCLIScript(version: String): String = + s""" + |/* + | * Licensed to the Apache Software Foundation (ASF) under one or more + | * contributor license agreements. See the NOTICE file distributed with + | * this work for additional information regarding copyright ownership. + | * The ASF licenses this file to You under the Apache License, Version 2.0 + | * (the "License"); you may not use this file except in compliance with + | * the License. You may obtain a copy of the License at + | * + | * http://www.apache.org/licenses/LICENSE-2.0 + | * + | * Unless required by applicable law or agreed to in writing, software + | * distributed under the License is distributed on an "AS IS" BASIS, + | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + | * See the License for the specific language governing permissions and + | * limitations under the License. + | */ + |//> using scala 2.13 + |//> using dep "org.apache.pekko::pekko-stream:${version}" + |////> using jvm 11 + |object VerifyJDK9Classes { + | def main(args: Array[String]): Unit = { + | import org.apache.pekko.actor.ActorSystem + | import org.apache.pekko.stream.scaladsl.{ JavaFlowSupport, Source } + | + | import java.lang.System.exit + | import scala.concurrent.Await + | import scala.concurrent.duration.DurationInt + | implicit val system: ActorSystem = ActorSystem.create("test") + | val future = Source(1 to 3).runWith( + | JavaFlowSupport.Sink.asPublisher[Int](fanout = false).mapMaterializedValue { p => Review Comment: I have reviewed this for a while, i am kind of understand why this PR does. A simple `grep` pipeline connected to unzip results only checks some of the classes, once these class names change or delete, we have to upgrade the CI too. Another way that parse out the bytecode header, I think it was too complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
