GitHub user pjfanning added a comment to the discussion: Add new deleteObject functions to Persistence API
All in all, we are very possibly heading towards calling the next Pekko release 2.0.0. I don't like treating deleting no rows as a failure - especially since Pekko 1.0 doesn't treat it as failure. I would still argue that Future[Boolean] is a better return type than Future[Done]. The boolean result is true if a deletion happened and false if no row was deleted. A DB Exception would lead to a Future failed state wrapping the exception. I would prefer the new return type to be on new functions and to deprecate the existing deleteObject functions. I would argue strongly against the name `NotImplemented`. I know of APIs that use the term `NotImplemented` as meaning `Unsupported`. `NothingDeleted` or something like that would make more sense to me. But I think Boolean is simpler still. GitHub link: https://github.com/apache/pekko/discussions/1233#discussioncomment-8913481 ---- This is an automatically sent email for notifications@pekko.apache.org. To unsubscribe, please send an email to: notifications-unsubscr...@pekko.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
