He-Pin commented on code in PR #1406:
URL: https://github.com/apache/pekko/pull/1406#discussion_r1685709867
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Graph.scala:
##########
@@ -742,7 +742,7 @@ object GraphDSL extends GraphCreate {
new GenericGraph(s, gbuilder.delegate.result(s))
}
- final class Builder[+Mat]()(private[stream] implicit val delegate:
scaladsl.GraphDSL.Builder[Mat]) { self =>
+ final class Builder[+Mat](private[stream] implicit val delegate:
scaladsl.GraphDSL.Builder[Mat]) { self =>
Review Comment:
This change is fine, but it does break some binary compatibility, I'm using
Javadsl only in Java, so I think that should also apply to others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
