mdedetrich commented on PR #1406:
URL: https://github.com/apache/pekko/pull/1406#issuecomment-2241580515
For those that are concerned about MiMa, breaking binary compatible or proof
that any combination of implicits/currying in Scala just gets converted to a
flat parameter list in JVM bytecode, with the current version of
```scala
final class Builder[+Mat]()(private[stream] implicit val delegate:
scaladsl.GraphDSL.Builder[Mat])
```
This `.java` source file compiles
```java
package org.apache.pekko.stream.javadsl;
public class Test {
void raw() {
org.apache.pekko.stream.scaladsl.GraphDSL.Builder<Void> delegate =
new org.apache.pekko.stream.scaladsl.GraphDSL.Builder<>();
new GraphDSL.Builder<>(delegate);
}
}
```
And if you change `final class Builder` to
```scala
final class Builder[+Mat](private[stream] implicit val delegate:
scaladsl.GraphDSL.Builder[Mat])
```
It also compiles without any changes to the `.java` source. As mentioned
before if there was an issue MiMa would have picked this up anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
