raboof commented on code in PR #101:
URL: https://github.com/apache/pekko-grpc/pull/101#discussion_r1713595823
##########
project/Common.scala:
##########
@@ -79,6 +79,13 @@ object Common extends AutoPlugin {
"-Wconf:msg=unused import:silent",
"-Wconf:cat=feature:silent")),
Compile / console / scalacOptions ~=
(_.filterNot(consoleDisabledOptions.contains)),
+ // restrict to 'compile' scope because otherwise it is also passed to
+ // javadoc and -target is not valid there.
Review Comment:
```suggestion
// javadoc and --release is not valid there.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
