jrudolph commented on code in PR #590:
URL: https://github.com/apache/pekko-http/pull/590#discussion_r1747199960
##########
http-core/src/test/resources/reference.conf:
##########
@@ -6,4 +6,5 @@ pekko {
default-dispatcher.throughput = 1
}
stream.materializer.debug.fuzzing-mode = off
+ stream.testkit.all-stages-stopped-timeout = 20 s
Review Comment:
> My ultimate reasoning for making this change global is was to reduce
surprises for people writing future tests (i.e. giving more QoL to developers),
more specifically avoiding the "I just updated/wrote a test and now its failing
due to a finely tuned timeout and now I have to figure out that it was because
of that said timeout"
I agree with the goal of helping test writers but it's not good if tests
only succeed or fail after a long timeout. Event the old 2 second timeout might
have been somewhat of a test fixing bankruptcy issue where we didn't have the
time to make sure all tests run through in a timely fashion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
