mdedetrich commented on code in PR #590:
URL: https://github.com/apache/pekko-http/pull/590#discussion_r1750228482
##########
http-core/src/test/resources/reference.conf:
##########
@@ -6,4 +6,5 @@ pekko {
default-dispatcher.throughput = 1
}
stream.materializer.debug.fuzzing-mode = off
+ stream.testkit.all-stages-stopped-timeout = 20 s
Review Comment:
Thats definitely true, however its usually only one specific test per test
classes that requires an override (as an example with
`WebSocketIntegrationSpec` its only `send back 100 elements and then terminate
without error even when not ordinarily closed` that even needs the oeverride.
Basically its only tests which explicitly cancel some part of
request/response as part of what is being tested and given how big test suites
normally are in pekko-http it might not be enough of a difference to be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
