shakeeb-upstart commented on code in PR #313:
URL: https://github.com/apache/pekko-management/pull/313#discussion_r1774970903
##########
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala:
##########
@@ -35,39 +36,61 @@ final class Settings(system: ExtendedActorSystem) extends
Extension {
if (hasDefined(key)) Some(config.getString(key)) else None
}
- private val kubernetesApi =
system.settings.config.getConfig("pekko.discovery.kubernetes-api")
+ private val customSettings =
configNameSpace.map(system.settings.config.getConfig)
Review Comment:
I wanted to have access to the default configs as well, to have the ability
to override certain properties and not have to give all of them, for example in
my use case I am only gonna change the pod-namespace the rest are gonna be the
same as the defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
