pjfanning commented on code in PR #313:
URL: https://github.com/apache/pekko-management/pull/313#discussion_r1774980188
##########
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala:
##########
@@ -35,39 +36,61 @@ final class Settings(system: ExtendedActorSystem) extends
Extension {
if (hasDefined(key)) Some(config.getString(key)) else None
}
- private val kubernetesApi =
system.settings.config.getConfig("pekko.discovery.kubernetes-api")
+ private val customSettings =
configNameSpace.map(system.settings.config.getConfig)
Review Comment:
The com.typesafe:config library lets you fallback to other configs in
another namespace - see the 'withFallback' method.
In HOCON, you can define configs that import config settings from another
namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
